Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS REVIEW: Examples #47

Closed
3 tasks
rbeucher opened this issue Feb 3, 2022 · 2 comments
Closed
3 tasks

JOSS REVIEW: Examples #47

rbeucher opened this issue Feb 3, 2022 · 2 comments
Assignees

Comments

@rbeucher
Copy link

rbeucher commented Feb 3, 2022

  • Please consider merging README markdown files and PYTHON scripts into a Jupyter notebook.
    They are easier to read, especially on GitHub. You can also take the user through the step of installing the required Python dependencies...

  • Please don't expect user to have PETSc installed in their HOME directory as default...

  • Jupyter notebooks would also help to visualize the outcome of the models / Benchmarks. As it is now, users must run the model themselves to see the result and they don't have a mean of comparison. That is also where you should compare with other codes (I2VES, UNDERWORLD, STAGYY)

@rbeucher rbeucher changed the title JOSS Submission: Examples JOSS REVIEW: Examples Feb 3, 2022
@rbeucher
Copy link
Author

rbeucher commented Feb 3, 2022

I see the Benchmarks results are in the documentation. That's good. I would like to have them in some Jupyter notebooks as well.

@rbeucher
Copy link
Author

Thanks for doing this. It's much better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants