Rmserror #47
Merged
Rmserror #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggebbie
approved these changes
Oct 13, 2023
|
Regarding the additional functions not included here, if they are general enough, they can be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions
rmserrorandcontroladj- these are unweighted versions ofdatacostandcontrolcostI just added lines to
runteststhat check the functionality of these, wasn't quite sure what good values would be for all the different cases. Perhaps another commit with proper@tests for these would be good.Other thought - right now, the structure of BLUEs doesn't allow for you to index
yorx. I wrote versions of these methods in OPT2k that allow for some indexing, and then let you assess the rmserror of a particular sediment core over time or the controladj propagated to the surface. Not sure if this is something that it would be useful to add to BLUEs because it would force you to make some decisions about preferred structure, but happy to discuss it more.