-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track allocated buffers in rpc-server #7407
Comments
Have some other thought maybe off topic: |
Right now the |
* rpc : track allocated buffers ref: #7407 * rpc : pack rpc_tensor tightly
Currently the
rpc-server
doesn't perform any input validation and this may have security implications. Another problem is that it may create memory leaks if clients do not free allocated buffers before disconnect (PR #7378 tries to address this).I think we can address both issues by using
std::unordered_set
to track allocated buffers and perform some additional checks without any noticeable performance degradation.The text was updated successfully, but these errors were encountered: