Server enhancements - grammar segfault and helper titles. #5080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Aaah smacked down by the dreaded trailing whitespace. Reviewbot must be a python coder. |
ggerganov
approved these changes
Jan 23, 2024
|
Oh is that why they were written that way? Yes that would be great for
readability.
…On Tue, Jan 23, 2024, 07:52 Georgi Gerganov ***@***.***> wrote:
***@***.**** approved this pull request.
Nice!
Should we change the deps.sh script to output raw string literals?
—
Reply to this email directly, view it on GitHub
<#5080 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZP3DFPUBKHSGYS7EHHHCDYP5T25AVCNFSM6AAAAABCFOHDUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYGA2TIMBZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
After rebasing and fixing the EditorConfig Checker we can merge |
|
Thx. 👍 |
mofosyne
added
examples
Review Complexity : Medium
|
I think this PR is quite outdated - probably not relevant anymore? |
|
Good question. I'll take another look but I think the segfault fix on no grammar is still important. Unless another PR fixed it. |
|
Is this bug still present? Just chasing up older PRs to make sure it's not obsolete |
|
It looks like @ggerganov fixed this directly so no need anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the server example segfaults on a null context if the grammar can't be parsed. This is fixed.
I also added titles with helpful mouseover explanations in the UI to help people understand n_predict, top_k, etc: