Windows: reactivate sigint handler after each Ctrl-C #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgroeber9110
changed the title
|
Can someone with Windows confirm they see this issue on their machine and that this PR fixes the issue? |
Tested on windows 10, cmake 3.24.3, msvc and works. See conversation below where i interrupted several times successfully and still was able to continue the conversation. You can see where I interrupted since 'user:' is not printed. (also note that bob didn't mind assisting 😄)
edit: forgot to paste the before picture... the behavior is as described: you can interrupt 1 time, the 2nd time llama exits.
|
|
Also confirm this do fix the issue on Windows 10. |
prusnak
approved these changes
Apr 3, 2023
|
Thanks for the confirmations, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using main.exe on Windows in interactive mode, I found that only the first Ctrl-C would interrupt generation. If I later used Ctrl-C again, it always exited the application.
The reason appears to be what is described here: https://stackoverflow.com/questions/43959514/why-the-second-sigint-cant-be-captured-on-win32 - Windows will reset the SIGINT handler to default as soon as a signal was received.
My solution is to capture the signal again each time interactive mode is entered.