Revert "whisper : remove extra backend instance (huh?)" #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4caa64b.
jiahansu
pushed a commit
to WiseSync/whisper.cpp
that referenced
this pull request
May 28, 2024
This reverts commit 4caa64b.
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Aug 9, 2024
* tag 'v1.6.2': release : v1.6.2 Revert "whisper : remove extra backend instance (huh?)" (ggerganov#2182) server : fix typo (ggerganov#2181) ruby : update bindings (ggerganov#2154) release : v1.6.1 examples : add support for decoding input with ffmpeg (Linux) (ggerganov#2133) node : add flash_attn param (ggerganov#2170) ci: Update build.yml to suppress warnings about node.js versions (ggerganov#2166) release : v1.6.0 whisper : use flash attention (ggerganov#2152) talk-llama : reject runs without required arguments (ggerganov#2153) sync : ggml metal : support FA without mask + add asserts (llama/7278) ggml : add RPC backend (llama/6829) rm wait() (llama/7233) CUDA: add FP32 FlashAttention vector kernel (llama/7188) scripts : sync ggml-rpc
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
This reverts commit 4caa64b.
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
This reverts commit 4caa64b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2177
In #2152 I accidentally broke the per-state backend instances that are necessary for thread-safe parallel execution. This reverts the change
4caa64b(#2152)