Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lists in config values #189

Merged

Conversation

mangelajo
Copy link
Contributor

This may allow, for example using a list of flavors which could
not be compatible across clouds, but allowing to fall back.

For example:
os.flavor = ['mylab.4cpu.8gb.20hd', 'm1.large']

Will try the first one, and then the next one, if not found.

@mangelajo
Copy link
Contributor Author

I need to test it locally, but still don't know how. How do I set my modified plugin to be used in my local vagrant installation?

@mangelajo mangelajo force-pushed the enhancement/multiple-setting-values branch from 9a763aa to d113b21 Compare December 23, 2014 13:13
This may allow, for example using a list of flavors which could
not be compatible across clouds, but allowing to fall back.

For example:
  os.flavor = ['mylab.4cpu.8gb.20hd', 'm1.large']

Will try the first one, and then the next one, if not found.
@mangelajo mangelajo force-pushed the enhancement/multiple-setting-values branch from d113b21 to f6eb055 Compare December 23, 2014 15:47
@mangelajo
Copy link
Contributor Author

I now understand this can be done via regular expressions /....|....|..../ , but may be it's a more intuitive way (similar to what we have with floating ip pools).

The only gain here is usability, the functionality is already there.

@julienvey
Copy link
Collaborator

Hi Miguel and thanks for the contribution.

I agree with you, it would be more intuitive to allow an array of floating_ip_pool. But allowing the 2 syntax is a good idea.

To test the plugin locally, you can use bundle within the source directory, for instance:

bundle exec vagrant up

The other way to test it locally (from anywhere in your path), is to create a gem from the sources and install it with vagrant itself. In the source directory

gem build vagrant-openstack-provider.gemspec
vagrant plugin install vagrant-openstack-provider-<the current version of the gem>.gem

@ggiamarchi
Copy link
Owner

I just test it, LGTM

ggiamarchi added a commit that referenced this pull request Jan 2, 2015
@ggiamarchi ggiamarchi merged commit 60b8b85 into ggiamarchi:master Jan 2, 2015
@mangelajo
Copy link
Contributor Author

Thank you very much @julienvey & @ggiamarchi , I will keep contributing where I find the opportunity.

@julienvey julienvey added this to the 0.7 milestone Jan 5, 2015
@ggiamarchi
Copy link
Owner

@mangelajo Thanks again for your contribution. Don't hesitate to continue to contribute if you wish. Feel free to have a look on the non assigned issues and to pick one. Just comment the issue to inform you're working on.

@ggiamarchi ggiamarchi modified the milestones: 0.7, 0.6.1 Jan 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants