-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lists in config values #189
Allow lists in config values #189
Conversation
I need to test it locally, but still don't know how. How do I set my modified plugin to be used in my local vagrant installation? |
9a763aa
to
d113b21
Compare
This may allow, for example using a list of flavors which could not be compatible across clouds, but allowing to fall back. For example: os.flavor = ['mylab.4cpu.8gb.20hd', 'm1.large'] Will try the first one, and then the next one, if not found.
d113b21
to
f6eb055
Compare
I now understand this can be done via regular expressions /....|....|..../ , but may be it's a more intuitive way (similar to what we have with floating ip pools). The only gain here is usability, the functionality is already there. |
Hi Miguel and thanks for the contribution. I agree with you, it would be more intuitive to allow an array of floating_ip_pool. But allowing the 2 syntax is a good idea. To test the plugin locally, you can use bundle within the
The other way to test it locally (from anywhere in your path), is to create a gem from the sources and install it with vagrant itself. In the
|
I just test it, LGTM |
…alues Allow list for flavors in config
Thank you very much @julienvey & @ggiamarchi , I will keep contributing where I find the opportunity. |
@mangelajo Thanks again for your contribution. Don't hesitate to continue to contribute if you wish. Feel free to have a look on the non assigned issues and to pick one. Just comment the issue to inform you're working on. |
This may allow, for example using a list of flavors which could
not be compatible across clouds, but allowing to fall back.
For example:
os.flavor = ['mylab.4cpu.8gb.20hd', 'm1.large']
Will try the first one, and then the next one, if not found.