Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxies with rsync #301

Closed
wants to merge 1 commit into from

Conversation

brijs
Copy link

@brijs brijs commented Sep 2, 2016

Use the proxy command specified in ssh.proxy_command for rsync
Fixes #300

Use ssh.proxy_command to translate to "-o ProxyCommand" in ssh(rsync)
@coveralls
Copy link

coveralls commented Sep 2, 2016

Coverage Status

Coverage increased (+0.008%) to 91.638% when pulling 8251923 on brijs:rsync-proxy-support into 4a25291 on ggiamarchi:master.

@brijs
Copy link
Author

brijs commented Sep 2, 2016

Fixes #300

@brijs
Copy link
Author

brijs commented Oct 1, 2016

@ggiamarchi this is a very simple fix. Does this look good to you for merge?

@ggiamarchi
Copy link
Owner

@brijs The provider has moved now to the standard vagrant synced folders middleware. The legacy rsync middleware within this provider is still available for now (use_legacy_synced_folders = true) but will be removed in a further release. By the way, the legacy implementation is no longer maintained. Thanks for your contribution.

@ggiamarchi ggiamarchi closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants