Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out version checks #358

Closed
wants to merge 1 commit into from
Closed

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Mar 7, 2018

I realize this is a partial fix that's unlikely to be accepted, but let me make the case and we can see where we can end up. These version checks are highly annoying for multiple reasons.

  • They require internet access on every command. This is a privacy concern because it leaks when you're using vagrant. It's also not guaranteed to be available.
  • They print warnings to stdout which breaks commands like vagrant ssh-config
  • There is no way to deactivate them. I know I installed a custom version because I needed fixes not available in a released version.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.74% when pulling a9d9c46 on ekohl:remove-version-checks into 4ee2d59 on ggiamarchi:master.

@ggiamarchi
Copy link
Owner

@ekohl As you expected, this PR won't be accepted but I agree this is a real issue.

A fix is provided by #365

@ggiamarchi ggiamarchi closed this Jul 24, 2018
@ekohl ekohl deleted the remove-version-checks branch July 26, 2018 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants