ggally_sumarise_by(), ggally_crosstable() and ggtable() #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add argument to remove background
* Rename `remove_{,xy}_axis` to `remove_percentage_axis`
* Change default for `remove_percentage_axis` to FALSE
* Update the axis to display as percentage
* If the axis is not displayed, also turn off the grid lines
schloerke
reviewed
May 31, 2020
schloerke
reviewed
May 31, 2020
schloerke
reviewed
May 31, 2020
schloerke
reviewed
May 31, 2020
schloerke
requested changes
May 31, 2020
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
|
Requested changes have been made (including name change). stat_cross() has been modified for proper handling of cells with zero observations. a vignette for |
larmarange
changed the title
schloerke
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of
ggtable()is to reproduce the need raised in #317.For this, I developed a variation of
ggally_table()calledggally_table2(). In addition, I'm also proposing in this PR the functionggally_summarised_by()previously mentionned.Of course, a dedicated vignette for
ggtable()will be proposed soon.