Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc-v2.0.0 #364

Merged
merged 23 commits into from
Jun 8, 2020
Merged

rc-v2.0.0 #364

merged 23 commits into from
Jun 8, 2020

Conversation

schloerke
Copy link
Member

@schloerke schloerke commented Jun 4, 2020

  • bump version
  • Fix GGally CRAN errors
  • devtools::check_win_devel(), devtools::check_win_release(), devtools::check_win_oldrelease()
    • submit
    • pass
  • source("scripts/rhub.R") has too many runtime problems
    • submit
    • pass
  • revdepcheck::revdep_check()
  • Update cran comments
  • devtools::release()
  • CRAN accepts GGally

@schloerke schloerke added this to the 2.0.0 milestone Jun 4, 2020
@schloerke schloerke self-assigned this Jun 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #364 into master will decrease coverage by 0.25%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   85.64%   85.38%   -0.26%     
==========================================
  Files          33       34       +1     
  Lines        4026     4038      +12     
==========================================
  Hits         3448     3448              
- Misses        578      590      +12     
Impacted Files Coverage Δ
R/deprecated.R 45.03% <ø> (ø)
R/gg-plots.R 75.11% <ø> (ø)
R/ggbivariate.R 0.00% <ø> (ø)
R/ggcoef.R 82.97% <ø> (ø)
R/ggcorr.R 99.33% <ø> (ø)
R/gglyph.R 100.00% <ø> (ø)
R/ggmatrix.R 100.00% <ø> (ø)
R/ggmatrix_legend.R 95.45% <ø> (ø)
R/ggnet.R 99.64% <ø> (ø)
R/ggnet2.R 99.03% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1699bf...ea372b1. Read the comment docs.

@schloerke
Copy link
Member Author

cc @larmarange

@schloerke
Copy link
Member Author

For some reason, Hmisc is failing on mac devel. There was no code change to warrant this. I am going to believe this is a false positive.

* master:
  weighted_mean_sd and weighted_median_iqr instead of mean_sd and median_iqr
  change default legend in ggtable
  change default fill scale
@schloerke schloerke merged commit 5b2c576 into master Jun 8, 2020
@schloerke schloerke deleted the rc-v2.0.0 branch June 8, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants