Upgrade Job-DSL dependency to 1.42 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace job with freeStyleJob and view with listView in most tests. Remove tests that check for an exception to be thrown when no job name is provided, since the new Job DSL syntax requires the job name as a parameter. Also the name method does not exist in Job DSL anymore, so replace usages with calls to the setter method for name. javaposse.jobdsl.dsl.JobType was removed, so instead use the simlar class com.terrafolio.gradle.plugins.jenkins.jobdsl.DSLJobType. Also add a direct dependency to Guava because it was removed from Job DSL.
mnonnenmacher
force-pushed
the
update-job-dsl
branch
from
4d37598
to
534b751
Compare
mnonnenmacher
changed the title
|
+1 - waiting for a new release :) |
|
Hrm... a manual build of @mnonnenmacher's PR leads to the following exception for me: and that happens right at the time the plugin is applied via |
|
@tommyd3mdi, I had similar issues before cleaning the project, but after a "gradlew clean" it did work. Did you try this already? |
|
Thanks for your effort! ;-) |
|
@ghale Could you please merge this and release a new version? |
|
@ghale I'm also waiting for a new release with this merged :-) |
|
Sorry for the lack of movement on this. I've just been struggling to find the time to work on my side projects. I promise I will try to find some time to merge this and cut a new release in the next few days. Thanks for being (overly) patient. |
|
Waiting for this as well. |
|
Thanks for the contribution! This is in v1.3.2. |
|
Thats great, but now i get an error: I am just using |
|
@oliverbestmann @ghale Thanks for the new version! |
|
Here's my build.gradle buildscript to add the missing dependencies mentioned by oliverbestmann plugins { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace job with freeStyleJob and view with listView in most tests.
Remove tests that check for an exception to be thrown when no job name is
provided, since the new Job DSL syntax requires the job name as a
parameter. Also the name method does not exist in Job DSL anymore, so
replace usages with calls to the setter method for name.
javaposse.jobdsl.dsl.JobType was removed, so instead use the simlar class
com.terrafolio.gradle.plugins.jenkins.jobdsl.DSLJobType.