Extend type support for dates and timestamps #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghdna Any chance I can get this reviewed, please? Thank you! |
|
Yes, will check it out this weekend. |
Optionally (defaults to false) cast date, timestamp, and timestamp with time zone data types to JS Date objects. Query method doesn't expose the data type forcing developers that want to operate with Date objects to track which columns are dates and perform the cast themselves. Dates and timestamps are casted to JS Date types using Luxon library. The code uses the method to transform SQL formats, consistent with Presto/Trino documentation. The code uses Luxon, and as such, it requires ICU full extension to work. ICU full mode is available by default starting on Node v13, but needs to be configured for previous versions of Node.
|
Included the dependencies in |
|
Gentle reminder |
|
Can we do this without adding another library as dependency? It increases maintenance down the road. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally (defaults to false) cast date, timestamp, and timestamp with
time zone data types to JS Date objects. Query method doesn't expose the
data type forcing developers that want to operate with Date objects to
track which columns are dates and perform the cast themselves.
Dates and timestamps are casted to JS Date types using Luxon library.
The code uses the method to transform SQL formats, consistent with
Presto/Trino documentation.
The code uses Luxon, and as such, it requires ICU full extension to
work. ICU full mode is available by default starting on Node v13, but
needs to be configured for previous versions of Node.
Resolves #49