Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added isolation functionality (GSI-503) #7

Merged
merged 10 commits into from
Dec 4, 2023

Conversation

KerstenBreuer
Copy link
Contributor

Added functionality for isolating a resource including its dependencies from
a provided datapack, i.e. rooting the datapack to that resource.

Rooting is no longer determined by the schemapack. Instead the decision if something is rooted or not is solely with the datapack. The same schemapack applies to rooted and unrooted datapacks.
Added functionality for isolating a resource including its dependencies from
a provided datapack, i.e. rooting the datapack to that resource.
Copy link

github-actions bot commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7057578391

  • 47 of 61 (77.05%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 94.388%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/schemapack/exceptions.py 2 5 40.0%
src/schemapack/isolate.py 45 56 80.36%
Totals Coverage Status
Change from base Build 7033304358: -1.7%
Covered Lines: 656
Relevant Lines: 695

💛 - Coveralls

Cito
Cito previously approved these changes Nov 30, 2023
src/schemapack/isolate.py Outdated Show resolved Hide resolved
src/schemapack/isolate.py Outdated Show resolved Hide resolved
src/schemapack/isolate.py Outdated Show resolved Hide resolved
src/schemapack/isolate.py Show resolved Hide resolved
Co-authored-by: Christoph Zwerschke <cito@online.de>
KerstenBreuer and others added 2 commits December 1, 2023 09:26
Co-authored-by: Christoph Zwerschke <cito@online.de>
Co-authored-by: Christoph Zwerschke <cito@online.de>
@KerstenBreuer KerstenBreuer merged commit 26e8357 into main Dec 4, 2023
3 checks passed
@KerstenBreuer KerstenBreuer deleted the feature/isolate_GSI-503 branch December 4, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants