Boolean config options #88
Conversation
tests/test_errors.py
Outdated
| @@ -21,7 +21,7 @@ def test_episode_already_exists_raise_exception(self): | |||
| existing_path = os.path.join(self.files, filename) | |||
| with open(existing_path, 'w'): | |||
| with raises(PathExistsException): | |||
| self.tv.rename(fn, existing_path) | |||
| self.tv.rename(fn, existing_path, symlink=False) | |||
There was a problem hiding this comment.
Rather than update this test can you make the symlink arg default to False in the rename method please. That will better signify it's an optional parameter to the method.
tvrenamr/cli/core.py
Outdated
| @click.option('--symlink', is_flag=True, help="Create symbolic links instead of moving the files. Requires '--rename-dir'.") # noqa | ||
| @click.option('-t', '--the', is_flag=True, help="Set the position of 'The' in a show's name to the end of the show name") # noqa | ||
| @click.option('--symlink', is_flag=True, default=None, help="Create symbolic links instead of moving the files. Requires '--rename-dir'.") # noqa | ||
| @click.option('-t', '--the', is_flag=True, default=None, help="Set the position of 'The' in a show's name to the end of the show name") # noqa |
There was a problem hiding this comment.
Could you expand on why these cli option changes were necessary?
There was a problem hiding this comment.
Because otherwise the default value from click will override the config, even if the user didn't call that option. Check my comment on the issue #87!
There was a problem hiding this comment.
Aha, I missed that comment somehow! I'm happy with this solution 👍
|
Sorry, I accidentally clicked close on my touchscreen. |
|
Thanks for approving! Sorry, but I don't really know, what does that mean. Do I need to do something right now? Or you'll just merge it later? |
|
@ata2001 – just that I approved the changes you made based on my previous feedback. Thanks again for these changes, you've been a real powerhouse, it's really appreciated :) |
|
Released in 4.3.0 on the PyPI |
No description provided.