Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Stripe marketplace methods more idiomatic #18

Closed
ghidinelli opened this issue Apr 18, 2015 · 1 comment
Closed

Make Stripe marketplace methods more idiomatic #18

ghidinelli opened this issue Apr 18, 2015 · 1 comment

Comments

@ghidinelli
Copy link
Owner

Review of marketplace appears to have multiple highly-overlapping methods where just the arguments change:

purchase()
charge()
marketplaceDirectCharge()
marketplaceDestinationCharge()

The behavior, depending on the parameters, is quite different but this more clearly matches the Stripe API too so collapsing them into the cfpayment-standard methods makes sense.
@ghidinelli
Copy link
Owner Author

All marketplace functions take an "amount" argument which should be "money".

ghidinelli added a commit that referenced this issue May 31, 2015
@ghidinelli
Fixing up Stripe Marketplace - fixes #22, #21, #20, #18, #17
3ca3ac2
@ghidinelli ghidinelli mentioned this issue May 31, 2015
Closed
@ghidinelli ghidinelli mentioned this issue May 31, 2015
Closed
cybersonic pushed a commit to cmd-ltd/cfpayment that referenced this issue Jun 21, 2017
@ghidinelli
Fixing up Stripe Marketplace - fixes ghidinelli#22, ghidinelli#21, gh…
54edab1 
…idinelli#20, ghidinelli#18, ghidinelli#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghidinelli