Add dataset tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lter_by_time(), modify the default None behaviour to choose utcnow() instead of now() to avoid timezone related issues
… add_dataset_tests
… add_dataset_tests
ghiggi
approved these changes
Sep 15, 2023
| """Set dataset attributes for each attrs_dict key.""" | ||
| for var in attrs_dict: | ||
| ds[var].attrs.update(attrs_dict[var]) | ||
|
|
There was a problem hiding this comment.
Not necessarily to be addressed in this PR, but let's try to update the code to return the ds in such type of functions ;)
So that ds = set_whatever(ds)
| dataarray = xr.DataArray(array, dims=["used_dim"]) | ||
| dataset = xr.Dataset(data_vars={"var": dataarray}) | ||
| dataset = dataset.expand_dims(dim=["unused_dim"]) | ||
| # TODO: this does not work, it adds the dimension to all variables. How can this be done? |
There was a problem hiding this comment.
I see. I guess to create the test case, you need to create two data arrays, then to one of them you call the expand_dims, then you xr.merge, and then you drop the variable with the "unused dim".
It might be that you need to define the dimension coordinate to avoid that by dropping the variable it drops also the dimension (because completely unused)
|
I'll address your comment on |
|
@sphamba can I merge now? |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and communicate accordingly:
The PR fulfills these requirements:
bugfix-<some_key>-<word>doc-<some_key>-<word>tutorial-<some_key>-<word>feature-<some_key>-<word>refactor-<some_key>-<word>optimize-<some_key>-<word>fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Summary