Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand io test coverage #37

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Expand io test coverage #37

merged 7 commits into from
Feb 9, 2024

Conversation

ghiggi
Copy link
Owner

@ghiggi ghiggi commented Feb 7, 2024

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the branch named as follow :
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

I

@coveralls
Copy link

coveralls commented Feb 7, 2024

Coverage Status

coverage: 64.695% (+3.0%) from 61.695%
when pulling 25bc688 on add_multiple_downloads
into 59a1b48 on main.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (59a1b48) 61.69% compared to head (25bc688) 64.69%.

Files Patch % Lines
gpm_api/io/ges_disc.py 57.14% 6 Missing ⚠️
gpm_api/io/download.py 95.83% 2 Missing ⚠️
gpm_api/io/checks.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   61.69%   64.69%   +3.00%     
==========================================
  Files          62       62              
  Lines        5498     5529      +31     
==========================================
+ Hits         3392     3577     +185     
+ Misses       2106     1952     -154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiggi ghiggi changed the title Expand download test coverage Expand io test coverage Feb 8, 2024
@ghiggi ghiggi merged commit ed087a3 into main Feb 9, 2024
31 of 34 checks passed
@ghiggi ghiggi deleted the add_multiple_downloads branch June 27, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants