Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download for Windows #49

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Fix download for Windows #49

merged 7 commits into from
Mar 30, 2024

Conversation

ghiggi
Copy link
Owner

@ghiggi ghiggi commented Mar 30, 2024

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow :
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Summary

Fix download on Windows operating systems.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 87.56%. Comparing base (57184b5) to head (5b3b87f).

Files Patch % Lines
gpm/io/download.py 40.38% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   87.76%   87.56%   -0.20%     
==========================================
  Files         110      110              
  Lines       10459    10501      +42     
==========================================
+ Hits         9179     9195      +16     
- Misses       1280     1306      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Mar 30, 2024

Coverage Status

coverage: 87.563% (-0.2%) from 87.762%
when pulling 5b3b87f on add-tutorials
into 57184b5 on main.

@ghiggi ghiggi merged commit 3df13b6 into main Mar 30, 2024
25 of 30 checks passed
@ghiggi ghiggi deleted the add-tutorials branch March 30, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants