Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): complex objects should work with all editors #296

Merged
merged 7 commits into from Oct 1, 2019

Conversation

ghiscoding
Copy link
Owner

  • add Jest unit tests for all Editors
  • increase code coverage for some Filters unit tests

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #296 into master will increase coverage by 9.64%.
The diff coverage is 99.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   86.68%   96.32%   +9.64%     
==========================================
  Files         134      134              
  Lines        7408     7536     +128     
  Branches     2549     2564      +15     
==========================================
+ Hits         6421     7258     +837     
+ Misses        987      278     -709
Impacted Files Coverage Δ
.../modules/angular-slickgrid/filters/sliderFilter.ts 100% <ø> (ø) ⬆️
...odules/angular-slickgrid/editors/checkboxEditor.ts 100% <100%> (+69.65%) ⬆️
...dules/angular-slickgrid/services/export.service.ts 100% <100%> (ø) ⬆️
.../modules/angular-slickgrid/editors/selectEditor.ts 98.89% <100%> (+84.6%) ⬆️
...es/angular-slickgrid/editors/autoCompleteEditor.ts 99.25% <100%> (+0.02%) ⬆️
...dules/angular-slickgrid/filters/dateRangeFilter.ts 99.2% <100%> (+0.06%) ⬆️
...pp/modules/angular-slickgrid/editors/textEditor.ts 100% <100%> (+73.62%) ⬆️
...modules/angular-slickgrid/editors/integerEditor.ts 100% <100%> (+80.22%) ⬆️
...p/modules/angular-slickgrid/editors/floatEditor.ts 100% <100%> (+82.5%) ⬆️
...es/angular-slickgrid/filters/compoundDateFilter.ts 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a5b55...07171d8. Read the comment docs.

@ghiscoding ghiscoding merged commit 0b67fea into master Oct 1, 2019
@ghiscoding ghiscoding deleted the feat/tests-input-editors branch October 16, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants