Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

feat(sort): add valueCouldBeUndefined column flag to help sorting #429

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

ghiscoding
Copy link
Owner

  • this is an opt-in flag because it could bring unwanted behavior and for example it breaks the Row Detail UI when sorting undefined values, so user can opt-in but it's off by default

- this is an opt-in flag because it could bring unwanted behavior and for example it breaks the Row Detail UI when sorting undefined values, so user can opt-in but it's off by default
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #429 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #429    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          141       141            
  Lines         8888      8891     +3     
  Branches      2942      3073   +131     
==========================================
+ Hits          8888      8891     +3     
Impacted Files Coverage Δ
...modules/angular-slickgrid/sorters/dateUtilities.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/sorters/numericSorter.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/sorters/sorterUtilities.ts 100.00% <100.00%> (ø)
.../modules/angular-slickgrid/sorters/stringSorter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cf1b4...0a43e8d. Read the comment docs.

@ghiscoding ghiscoding merged commit dcd7a41 into master Apr 9, 2020
@ghiscoding ghiscoding deleted the feat/sort-undefined-values branch April 9, 2020 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants