Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add new Dual Input Editor & extract all Editor Validators #446

Merged
merged 1 commit into from
May 5, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 5, 2020

  • note that there are no supported dual input filter with dual input editor

Preview

image

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #446 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #446    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          141       147     +6     
  Lines         8957      9189   +232     
  Branches      2971      3053    +82     
==========================================
+ Hits          8957      9189   +232     
Impacted Files Coverage Δ
...gular-slickgrid/editorValidators/floatValidator.ts 100.00% <100.00%> (ø)
...odules/angular-slickgrid/editorValidators/index.ts 100.00% <100.00%> (ø)
...lar-slickgrid/editorValidators/integerValidator.ts 100.00% <100.00%> (ø)
...ular-slickgrid/editorValidators/sliderValidator.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/editorValidators/textValidator.ts 100.00% <100.00%> (ø)
...es/angular-slickgrid/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/editors/floatEditor.ts 100.00% <100.00%> (ø)
src/app/modules/angular-slickgrid/editors/index.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/editors/integerEditor.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e2973...4862ae3. Read the comment docs.

@ghiscoding ghiscoding merged commit 06f5dc9 into master May 5, 2020
@ghiscoding ghiscoding deleted the feat/dual-input-editor branch May 5, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants