fix(collectionAsync): hidden column does not load edit field selection

[mcallegario]

Bug: Hidden column does not load edit field with selection options

The "this.slickGrid.getColumns()" method only returns the visible fields of the grid, so if the field that was configured to return a list of elements (collectionAsync) is hidden in the grid, it does not receive the list of elements.

note: Unfortunately after version 1.3.x I am no longer able to perform the "pnpm run build".

[ghiscoding]

yeah don't use the build (which is meant for something else), use the bundle instead which will delete all previous dist folders and avoid the problem you're seeing

[ghiscoding]

please remove this line and apply it directly as shown below

- const columns = this.columnDefinitions;
if (Array.isArray(columns)) {
-        const columnRef = columns.find((col: Column) => col.id === column.id);
+        const columnRef = this.columnDefinitions.find((col: Column) => col.id === column.id);

[mcallegario]

to remove the "const columns" I also have to change the "if" list. Is it good like this?

[ghiscoding]

that seems correct, are you going to be able to fix the unit tests or do you need help? Please don't comment out the unit tests, we need to keep track of them and not forget them please :)

[codecov]

Codecov Report

Merging #742 (ffc1a36) into master (c8acb65) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #742   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          233       233           
  Lines        16437     16439    +2     
  Branches      5490      5490           
=========================================
+ Hits         16437     16439    +2     

Impacted Files	Coverage Δ
...bundle/src/components/slick-vanilla-grid-bundle.ts	100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts	100.00% <0.00%> (ø)
packages/common/src/filters/sliderFilter.ts	100.00% <0.00%> (ø)
packages/common/src/extensions/extensionUtility.ts	100.00% <0.00%> (ø)
...ackages/common/src/filters/compoundSliderFilter.ts	100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ghiscoding]

@mcallegario
Thanks for the PR, this was released under new version v1.4.0, thanks again for the contribution 😉