Add SnapshotTest #2233
Merged
Add SnapshotTest #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reads `CI` environment variable (same as sbt) to determine if we're running in CI. This variable determines which behaviour the tests have - If we're running in CI it checks that the contents of all the snapshot files are up to date - Otherwise, it'll update the files with new contents. The point is that a given change will showcase the effective results right in the PR, and otherwise be convenient to work with
|
a cool thing here for later would be to verify that the code compiles as well |
There is the |
Ah never mind, I think it's for strings known at compile time only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads
CIenvironment variable (same as sbt) to determine if we're running in CI.This variable determines which behaviour the tests have
The point is that a given change will showcase the effective results right in the PR, and otherwise be convenient to work with
Extracted from #2216