-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter containing asterisk followed by equals sign does not match #2184
Comments
This is interesting. If the filter is by itself, it matches. |
Narrowed it down to this combination from EasyPrivacy:
The above combination does not match, but if the first filter is removed then the second filter matches. This must have something to do with tokenization. |
I have a fix: #2187 |
Fixed. |
This is based on the adblocker-benchmarks package:
cliqz.diff.json
Expected result
The URL
https://src.ebay-us.com/ofc8lb2zw9xlwgan.js?8kkzfaannqhvf4w3=usllpic0&3ovsbiogi5cyl9c9=31ceb2d517b0a45e36136c3cfffba69d
should be blocked by the filter||src.ebay-us.com/*=usllpic$script,domain=ebay.com
Actual result
The URL is not blocked.
More details
It's the same filter each time:
||src.ebay-us.com/*=usllpic$script,domain=ebay.com
. It's matched by uBlock Origin but not by Cliqz.If the
=
beforeusllpic
is removed, it works.If the
=
is replaced with a^
, it still does not work.The text was updated successfully, but these errors were encountered: