Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm error on linux #507

Closed
chrmod opened this issue Feb 18, 2021 · 1 comment · Fixed by #511
Closed

npm error on linux #507

chrmod opened this issue Feb 18, 2021 · 1 comment · Fixed by #511
Labels
bug Something isn't working

Comments

@chrmod
Copy link
Member

chrmod commented Feb 18, 2021

I've been making more than enough issues, and I've wanted to contribute, but I have the following error when trying to build.

I ran these commands:

git clone https://github.com/ghostery/user-agent-desktop/
cd user-agent-desktop
npm ci

I got the error at https://gist.github.com/2br-2b/8c5d9f7f0f683f3671ae7a8c844465ce

What is going wrong? I assumed it was an error with the wrong version of python with some feature not included in this version of python, hence the error platform is not implemented yet.

I'm running Linux Mint, and it seems to be trying to work with some macos files. I'm guessing that whatever it's trying to do is not supported on Linux and only on Macs and/or Windows.

This will be my first time contributing to Firefox or any of its forks, so I want to make sure I get the environment set up right.

Thank you for your help!

Originally posted by @2br-2b in #497

@chrmod chrmod added the bug Something isn't working label Feb 18, 2021
@remusao
Copy link
Contributor

remusao commented Feb 18, 2021

After some further investigation it seems like the issue is from appdmg which is not compatible with Linux (I think?). When removing it from package.json and running npm install the issue is gone. A possible fix is to remove it from package.json and use npx appdmg from sign_mac.sh for CI.

chrmod added a commit that referenced this issue Feb 18, 2021
appdmg was causing issue on some Linux system and as we only need it on MacOS we can access it via npx

fix #507
chrmod added a commit that referenced this issue Feb 18, 2021
* Remove appdmg from dependencies

appdmg was causing issue on some Linux system and as we only need it on MacOS we can access it via npx

fix #507

* Fern: use md5 for file name hashes

on ext4 for some urls the generated base64 file name was too long

* use node crypto instead of md5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants