Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include vignettes in package documentation #46

Closed
wants to merge 4 commits into from

Conversation

n8thangreen
Copy link
Contributor

vignettes are available in help files

@giabaio
Copy link
Owner

giabaio commented Feb 26, 2023

Hi @n8thangreen --- sorry, but I think I cleaned up the design of the repo (following, also, your comments). I have moved the old 'main to cran (that's the stable version on CRAN); dev to main (this is actually the version we have now, which we could move to CRAN soon, fully working); I've kept also a copy of dev, which at the moment is the same as main. But I think we should have the following structure

  • main: the main stable version (which isn't necessarily the same as CRAN), but it's stable
  • cran: exactly the same as the CRAN version
  • dev: where we test changes

You may argue that we don't really need cran, but we may soon realise that it has some bugs/issues, so I guess having a working, stable main may be a good thing? What do you think?

So: lots of text to say, could you please re-do the pull request onto main too? (Can you do the same PR to two separate branches?). I'll wait to see what you find out at your end before merging this into dev...

Thanks!

@n8thangreen
Copy link
Contributor Author

Thanks. No problems with this. The alternative is to use the release/version feature of GitHub instead of the CRAN branch. I'll close this PR and do another like to say. I see that I've broken the checks too! So I'll fix them first..

@giabaio
Copy link
Owner

giabaio commented Feb 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants