Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BLASFEO_INCLUDE_DIR user definable #80

Closed
nielsvd opened this issue May 5, 2020 · 1 comment
Closed

Make BLASFEO_INCLUDE_DIR user definable #80

nielsvd opened this issue May 5, 2020 · 1 comment

Comments

@nielsvd
Copy link
Contributor

nielsvd commented May 5, 2020

Here the BLASFEO_INCLUDE_DIR is forced to be ${BLASFEO_PATH}/include. In blasfeo, the option BLASFEO_HEADERS_INSTALLATION_DIRECTORY is however configurable. It would therefore be more appropriate if BLASFEO_INCLUDE_DIR could be provided as an option. Either by making it an option() explicitly or by writing

set(BLASFEO_INCLUDE_DIR "${BLASFEO_PATH}/include" CACHE STRING "Path to BLASFEO header files.")

instead of

set(BLASFEO_INCLUDE_DIR "${BLASFEO_PATH}/include")
@giaf
Copy link
Owner

giaf commented May 13, 2020

This should be implemented now.

@nielsvd nielsvd closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants