Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes to flowAI package #10

Open
timmocking opened this issue May 16, 2022 · 7 comments
Open

Recent changes to flowAI package #10

timmocking opened this issue May 16, 2022 · 7 comments

Comments

@timmocking
Copy link

Hi,

I noticed you made some commits recently. In my own work, I noticed a great change before and after updating the package. The changes I notice are an improved sensitivity in the peak detection (FR) and less false-positive segments (FS). What exactly are the changes you made?

@giannimonaco
Copy link
Owner

giannimonaco commented May 17, 2022 via email

@timmocking
Copy link
Author

Got it. This seems to correspond to my results. The standard cut-off of 0.01 does seem to be overly sensitive when using MAD, in my experience. I will stick to IQR! Did you also make changes for the FS detection?

MAD, Alpha FR = 0.01

image

MAD, Alpha FR = 0.001

image

IRQ, Alpha FR = 0.01

image

MAD, Alpha FR = 0.01

image

@giannimonaco
Copy link
Owner

Thank you for sharing your results! Yes, IQR is less sensitive and it might work well in many cases.
I did not make any change on the FS detection methods, however I made a small change on how percentage of outlier bins are calculated when "outlier_binsFS = TRUE".
However, in case you noticed some noticeable difference between two particular flowAI versions, let me know and I'll look it up..

@SamGG
Copy link
Contributor

SamGG commented Mar 28, 2024

@timmocking You have got interesting examples. Could you share them with me?

@timmocking
Copy link
Author

@SamGG Unfortunately I created these plots almost 2 years ago, so I don't recall which samples I used here..

@SamGG
Copy link
Contributor

SamGG commented Apr 2, 2024

@timmocking Thanks for your feedback. From figures 3&4, it seems that the flow rate could vary slowly. But the filtering is based on a constant flow rate, which does not fit. I am thinking that the goal of flow rate based filtering is to identify an eventual ending spike and the very low flow rate. Do you have an opinion about flow rate based filtering?

@timmocking
Copy link
Author

@SamGG I'm unfamiliar with the exact causes of long-range flow rate changes. For any of these QC packages (flowAI, PeacoQC, flowCut), I believe the key question is whether the fluctuation affects the consistency of fluorescent signals throughout the measurement. Any tool that assesses these, should probably benefit from considering those signals directly rather than indirectly through the flow rate. An exception could be made for these flow rate spikes, which might not result in a large anomaly at the global level.

However, I have not seen much data indicating that flow rate anomalies cause significant changes in fluorescent intensity. Also, they often comprise maybe 1-2% of the events and are much less "outlier" than other worrisome events such as doublets, debris, and margin events.

I would be convinced if someone showed a comparison in model quality (automated gating, better clustering, disease classification, etc.) comparing data that includes or does not include flow rate anomalies. I might be able to do this in the near future, I will let you know what I find 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants