Create new date input and replace all the existing ones with it #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axbarsan
commented
Feb 19, 2021
| > | ||
| <Input | ||
| // @ts-expect-error | ||
| ref={ref} |
There was a problem hiding this comment.
The props interface of the date input doesn't allow setting a ref, but it's actually supported 🧇
oponder
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/giantswarm#11004 and towards the grommet migration
This PR includes the new date input, snapshot tests and Storybook examples. It also replaces the date input in the keypair creation modal with the new one, getting rid of another dependency.
If specified a
format(e.g.yyyy-mm-dd), you can also enter the date via text, with a masked input (meaning you don't have to type the-between the years, months and days - similar to a phone field on some websits). Otherwise, the form acts as a button, which you can customize as you wish.The current button display is the
grommetdefault, so it will change once we will customize buttons. That's why the date button in the keypair creation modal currently uses a custom style.Preview
With label
With label - open
With multiple other configurations
With multiple other configurations - open
With a button instead of input
With a button instead of input - with value
With a button instead of input - open
Keypair creation modal
Keypair creation modal - date input open