Create textarea input #2187
Merged
Create textarea input #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axbarsan
commented
Feb 22, 2021
Comment on lines
-239
to
-255
|
|
||
| const kubeconfigContent = getByTitle(/kubeconfig/i).textContent; | ||
| const copyButton = getByText(/^copy$/i); | ||
| fireEvent.click(copyButton); | ||
| expect(setClipboardContentMockFn).toHaveBeenCalledWith(kubeconfigContent); | ||
| // @ts-ignore | ||
| useCopyToClipboard.mockReturnValueOnce([true, setClipboardContentMockFn]); | ||
|
|
||
| act(() => { | ||
| jest.runAllTimers(); | ||
| }); | ||
|
|
||
| const copiedSuccessLabel = getByTitle(/content copied to clipboard/i); | ||
| expect(copiedSuccessLabel).toBeInTheDocument(); | ||
|
|
||
| // @ts-ignore | ||
| useCopyToClipboard.mockClear(); |
There was a problem hiding this comment.
Removed the part that was testing copying to clipboard, that's already tested for the FileBlock component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/giantswarm#11004 and towards the grommet migration
This PR includes a new
textareainput. There were no components that I could add it to. There was one old usage oftextareain the keypair creation success modal, which was also not displayed correctly, and I replaced it with theFileBlockcomponent.Preview
With label
With error
With info message
With help message
Disabled
Keypair creation success modal - BEFORE
Keypair creation success modal - AFTER