Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions overview subject select form #3443

Merged
merged 15 commits into from
May 19, 2022

Conversation

gusevda
Copy link
Contributor

@gusevda gusevda commented May 18, 2022

Towards giantswarm/roadmap#1086.

In this PR UI for admin users to inspect other users/groups permissions was added. It's not ready to be merged into main branch, should be integrated with #3439 first.

Screenshot 2022-05-18 at 11 06 00

Screenshot 2022-05-18 at 11 06 14

@gusevda gusevda requested a review from a team May 18, 2022 08:09
@gusevda gusevda force-pushed the permissions-overview-admin-ui branch from 254f90d to 0f317f1 Compare May 18, 2022 08:25
Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We found some nitpicks to improve.

Copy link
Contributor

@kuosandys kuosandys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Thanks for making the subject form responsive as well!

@marians
Copy link
Member

marians commented May 19, 2022

Giving it a test drive now.

Is the gradient overlaying the scroll bar intentional? (Chrome, Mouse attached)

image

I'd also like to increase the space between scroll bar and content right above it by about 20 px.

@kuosandys kuosandys added the kind/feature Introducing a new feature label May 19, 2022
@marians
Copy link
Member

marians commented May 19, 2022

Intro text update:

Here you can check which <abbr title="role based access control">RBAC</abbr> permissions you have in the management cluster, with regard to certain use cases. As an admin, you can also inspect other users' and groups' permissions.

@kuosandys Are these apostrophes correct?

The HTML abbr is just an accessibility thing that occurred to me. Let's do that if possible.

@gusevda gusevda merged commit 8d7e73e into main May 19, 2022
@gusevda gusevda deleted the permissions-overview-admin-ui branch May 19, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants