Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node pool #774

Merged
merged 72 commits into from
Oct 7, 2019
Merged

Add node pool #774

merged 72 commits into from
Oct 7, 2019

Conversation

ograu
Copy link
Contributor

@ograu ograu commented Sep 25, 2019

AddNodePool component is basically copy/pasted from CreateCluster component and adapted to its needs: I removed everything related to Azure and KVM because AFAIK node pools aren't supported in Azure and KVM by now. Correct me if I'm wrong, please.

Also in this PR:

  • I've started to use Immer to update nested properties on local state object
  • I've started to add the HTML element name as a suffix in emotion styled variables. I think Marian does it as well (?). It makes JSX in render easier to read IMO.

Form view:

Captura de pantalla 2019-09-25 a las 13 10 36

With validation errors/messages (some adjustments to be made on margins):

Captura de pantalla 2019-09-25 a las 13 11 30

@ograu
Copy link
Contributor Author

ograu commented Oct 1, 2019

ping @marians

Now the form can switch from availability zones picker:

Captura de pantalla 2019-10-01 a las 10 22 26

To availability zones labels:

Captura de pantalla 2019-10-01 a las 10 23 03

In order to have clickable labels for availability zones I have:

  • Adapted AvailabilityZonesLabel and AvailabilityZonesLabels components to accept checked/unchecked state
  • Created a wrapper for AvailabilityZonesLabels responsible for passing the state in the correct shape to the form

This is how labels looks like when they are checked (A, B, C) and unchecked (D, E):

Captura de pantalla 2019-10-01 a las 10 19 39

@marians marians had a problem deploying to gauss October 1, 2019 10:36 Failure
@marians marians deployed to gauss October 1, 2019 10:45 Active
@marians marians deployed to gauss October 1, 2019 10:48 Active
@ograu
Copy link
Contributor Author

ograu commented Oct 1, 2019

  • Changed default values for scaling,
  • Maximum availability zones is 4 now
  • Improved validation and messages to the user for labels

Captura de pantalla 2019-10-01 a las 16 08 06

Captura de pantalla 2019-10-01 a las 18 42 32

@ograu ograu requested a review from marians October 2, 2019 16:31
@ograu
Copy link
Contributor Author

ograu commented Oct 2, 2019

ping @marians Just realized that you weren't added here as a reviewer...

Copy link
Member

@marians marians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together in a hangout and noted a few nitpicks, no blockers found.

@ograu
Copy link
Contributor Author

ograu commented Oct 7, 2019

In these lasts commits I made the modifications we've been discussing this morning:

  • Region: before region
  • 0 nodes when no the cluster has no node pools
  • Kubernetes endpoint copyable
  • Upgrade available underlined when hover
  • Added text To enable autoscaling, set minimum and maximum to different values. below picker
  • Changed background (too dark in my opinion)
  • Disable text selection highlighting in all AZ labels

Things I couldn't change:

  • Can't use the region instead AZ because in testing API we don't have the datacenter property on the object retrieved...

And finally, that weird spanis something that ReactCSSTransitionGroup is adding 🤷‍♂

I will merge it and when we have the region will update it.

Captura de pantalla 2019-10-07 a las 13 56 43

@ograu ograu merged commit bc91ce1 into master Oct 7, 2019
@ograu ograu deleted the add-node-pool branch October 7, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants