-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node pool #774
Add node pool #774
Conversation
ping @marians Now the form can switch from availability zones picker: To availability zones labels: In order to have clickable labels for availability zones I have:
This is how labels looks like when they are checked (A, B, C) and unchecked (D, E): |
ping @marians Just realized that you weren't added here as a reviewer... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested together in a hangout and noted a few nitpicks, no blockers found.
In these lasts commits I made the modifications we've been discussing this morning:
Things I couldn't change:
And finally, that weird I will merge it and when we have the region will update it. |
AddNodePool
component is basically copy/pasted from CreateCluster component and adapted to its needs: I removed everything related to Azure and KVM because AFAIK node pools aren't supported in Azure and KVM by now. Correct me if I'm wrong, please.Also in this PR:
Form view:
With validation errors/messages (some adjustments to be made on margins):