Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show an icon if the organization has credentials setup or not #850

Merged
merged 11 commits into from
Nov 25, 2019
Merged

Show an icon if the organization has credentials setup or not #850

merged 11 commits into from
Nov 25, 2019

Conversation

axbarsan
Copy link
Contributor

Fixes giantswarm/giantswarm#6630

  • Add getting credentials to getting organizations action
  • Show icons in the table view if the organization has credentials setup or not
  • Clean up code

What it looks like

Screenshot 2019-11-20 at 19 28 11

@axbarsan
Show an icon if the organization has credentials setup or not
c0f36bd 
- Add getting credentials to getting organizations action
- Show icons in the table view if the organization has credentials setup or not
- Clean up code
@axbarsan axbarsan requested review from a team November 20, 2019 18:30
@axbarsan axbarsan self-assigned this Nov 20, 2019
@marians
Copy link
Member

marians commented Nov 20, 2019

This new column would only make sense on AWS and Azure, not on KVM. I don't see any condition for this so far.

While I like that you are using an icon for this column, I don't find the ✖️ icon ideal. We use it for closing modals. Can we find an alternative? What do others think?

@axbarsan
Copy link
Contributor Author

This new column would only make sense on AWS and Azure, not on KVM. I don't see any condition for this so far.

While I like that you are using an icon for this column, I don't find the ✖️ icon ideal. We use it for closing modals. Can we find an alternative? What do others think?

I actually didn't know that, I'll make the change now.
I also agree about the icon, I'll look for another one.

Thank you 👍

@axbarsan
Replace provider credentials title and icon with more suitable ones, …
f86b4d1 
…and hide the column if the provider is 'kvm'
@oponder
Copy link
Contributor

oponder commented Nov 21, 2019

How about only using the CHECK icon and just leaving it blank for when there are no credentials?

@axbarsan
Copy link
Contributor Author

axbarsan commented Nov 21, 2019 •
edited
Loading

How about only using the CHECK icon and just leaving it blank for when there are no credentials?

Screenshot 2019-11-21 at 09 55 07

Looks pretty good. What do you think, @marians ?

@marians
Copy link
Member

marians commented Nov 21, 2019

Like it!

ograu
ograu suggested changes Nov 21, 2019
View reviewed changes
src/actions/organizationActions.js Outdated Show resolved Hide resolved
@axbarsan axbarsan requested a review from ograu November 21, 2019 12:46
ograu
ograu approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@ograu ograu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oponder
Copy link
Contributor

oponder commented Nov 25, 2019

Let's merge this?

@axbarsan axbarsan merged commit 3740af2 into master Nov 25, 2019
@axbarsan axbarsan deleted the Add-credential-check-to-orgs-list branch November 25, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marians marians marians approved these changes

@oponder oponder oponder approved these changes

@ograu ograu ograu approved these changes

Assignees

@axbarsan axbarsan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axbarsan @marians @oponder @ograu