Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImagePullSecrets not working #203

Open
ynctlm opened this issue Mar 20, 2023 · 0 comments
Open

ImagePullSecrets not working #203

ynctlm opened this issue Mar 20, 2023 · 0 comments

Comments

@ynctlm
Copy link

ynctlm commented Mar 20, 2023

Hi,

I guess the imagePullSecrets in the Helm chart are not working.

I think there are two issues:

  1. The type is currently object, it has to be array.

Fix for values.schema.json

      ...
      "imagePullSecrets": {
        "type": "array"
      `},`
      ...

Fix for values.yaml

...
imagePullSecrets: []
...
  1. The indentation of the imagePullSecret property in the deployment.yaml is off.

Fix for deployment.yaml

      ...
      securityContext:
        runAsUser: {{ .Values.pod.user.id }}
        runAsGroup: {{ .Values.pod.group.id }}
        {{- with .Values.podSecurityContext }}
          {{- . | toYaml | nindent 8 }}
        {{- end }}
      {{- with .Values.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      containers:
      ...

Maybe there is also another solution to fix this, but this is how I got it working locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant