Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql view params #146

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Sql view params #146

merged 3 commits into from
Apr 12, 2024

Conversation

iboates
Copy link
Collaborator

@iboates iboates commented Apr 12, 2024

Howdy howdy and happy Friday

I needed expanded functionality for specifying parameters in published SQL View layers, so I have implemented it into the publish_featurestore_sqlview method.

Specific things to note:

  • New optional parameter parameters, which is an iterable of dicts with names that correspond (snake_case to camelCase) to the necessary XML entries used by Geoserver to define the parameters for SQL Views (docs)
  • Totally reworked TestFeatures to account for these changes, and made it automatically build up the necessary database and geoserver content, and tearing it down at the end.
  • To the above point, I also expanded the stuff in tests/common.py to allow you to specify a database in which to run tests. Maybe some of the current "local only" tests can be refactored to use this as well.
  • Two new dev dependencies were introduced, I hope that that isn't a problem. They are sqlalchemy and psycopg2, used to work with the database when setting up & tearing down the database during testing.

Let me know what you think, I can tweak this further

iboates and others added 3 commits April 10, 2024 17:46
WIP adding functionality for passing sql view params
@iboates
Copy link
Collaborator Author

iboates commented Apr 12, 2024

😱 I completely missed this PR!

#144

Sorry about that..

Copy link
Collaborator

@iamtekson iamtekson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. Thank you for the valuable contribution @iboates.

@iamtekson iamtekson merged commit 553e82d into gicait:master Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants