Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy howdy and happy Friday
I needed expanded functionality for specifying parameters in published SQL View layers, so I have implemented it into the
publish_featurestore_sqlview
method.Specific things to note:
parameters
, which is an iterable of dicts with names that correspond (snake_case to camelCase) to the necessary XML entries used by Geoserver to define the parameters for SQL Views (docs)TestFeatures
to account for these changes, and made it automatically build up the necessary database and geoserver content, and tearing it down at the end.tests/common.py
to allow you to specify a database in which to run tests. Maybe some of the current "local only" tests can be refactored to use this as well.sqlalchemy
andpsycopg2
, used to work with the database when setting up & tearing down the database during testing.Let me know what you think, I can tweak this further