Generalize dataFromJson to allow JSON lists
#44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the wrapping of the JSON value into a singleton list. This allows passing complete datasets with all fields defined. Single values can simply be wrapped into a JSON list before passing to `dataFromJson`.
|
Thanks very much for raising this - much appreciated. I agree with you that this is (unintentionally) counterintuitive. I have made a few other minor changes to data generation functions so will make your suggested changes manually ready for the next release rather than merge the PR. |
|
OK great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am experimenting with
elm-vegaand found it counterintuitive thatdataFromJsonwraps the JSON value into another list.I think it is better to just assume that the JSON value is already a list. This allows passing complete datasets with all fields defined, which is currently not possible. To support the current usage, single values can simply be wrapped into a JSON list before passing them to
dataFromJson.Please see if this change makes sense to you.