-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UTC versions of TimeUnit #46
Conversation
Thanks very much for suggesting this. I had meant to add UTC time units in an earlier release so your prompt has been helpful. Rather than add a set of another 24 types to what is already rather a cumbersome set of time unit types, I would prefer to add a single encoding
<< position X [ PName "date", PmType Temporal, PTimeUnit (Utc YearMonthDateHours) ] I've created a |
Hi @jeffesp, thanks for this contribution! I see you've started to make a fork with your functionality that contains a new url. etc. Could you please do it in a new branch (e.g. |
Oops – commented simultaneously with @jwoLondon 😅 @jeffesp if you're fine with the new functionality in a different branch, no need to do anything – we'll simply close this PR later on. |
The changes in the |
OK, that's good to know - thanks. If you want to use the |
This isn't the prettiest change, but it seems to work in my local testing.
I'm unable to generate accurate graphs without it.