-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Data Retrieval: Implement Join Conditions #43
Enhanced Data Retrieval: Implement Join Conditions #43
Conversation
Pull Request Test Coverage Report for Build 8606035890Details
💛 - Coveralls |
@ZaidMaslouhi Thank you for the good work. I hope you are willing to add at least one example in the documenation here : https://github.com/gid-oss/dataui-nestjs-crud/blob/master/docs/requests.md#join ! Apart from that it's good to merge and release and I will do so soon after I hear from you on the docs. |
While at it guys, I really think that relations need to have ability to be paginated/sorted as well. Oh, Hi @zaro ! What a small world. We were colleagues at Concurrent ages ago :) |
Hi @zaro! |
@Dragomir-Ivanov Hey :) Indeed , quite some time ago. Regarding your suggestion, this is not the place to discuss it. If you want maybe open a new issue where this can be discussed properly. Because if I understand you correctly, this is actually quite complicated feature and most certainly not possible with a single SQL query. So maybe also provide a simple example in plain SQL how it is supposed to work. Keep in mind that this CRUD library is just a think layer over TypeORM and TypeORM itself doesn't have support for what you are requesting. Happy to hear more for you . |
@ZaidMaslouhi FYI: I think this is related to the docs you wrote? Maybe you can do the change if this is what happening? Thanks. |
Description:
This PR introduces join filters for dataui-nestjs-crud, empowering you with greater control over related data queries. Users can now specify WHERE conditions within the ON clause of joins, enabling the creation of more intricate and specific queries.
Key Improvements:
Implementation Details:
Benefits:
#38