Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic dependabot updates #18

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Enable automatic dependabot updates #18

merged 5 commits into from
Apr 30, 2024

Conversation

timomeh
Copy link
Member

@timomeh timomeh commented Apr 29, 2024

  • Enables automatic dependabot updates
  • Enables auto-merge of dependabot PRs for patch and minor semver dependency updates
  • Configured some dependency groups to group common dependencies together, so there's less PR noise
  • Adds storybook to CI, so we know that storybook still works
  • Fixes an old import path in storybook

@timomeh timomeh requested review from a team and osamaqarem and removed request for a team April 29, 2024 11:09
Copy link
Member

@osamaqarem osamaqarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

"you update dependencies"

I'm personally new to configuring dependabot - my understanding is that the current setup in the PR will still create PRs for major version upgrades but they won't be auto-merged.

If we don't want major version PRs to happen at all, it seems we could use use the updates-types key shown in this example.

@osamaqarem
Copy link
Member

osamaqarem commented Apr 29, 2024

If we don't want major version PRs to happen at all, it seems we could use use the updates-types key shown in this example.

Actually this is a the correct example:
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#specifying-dependencies-and-versions-to-ignore

@timomeh
Copy link
Member Author

timomeh commented Apr 29, 2024

Yes, good observations! If we don't want major versions for some dependencies, we could also tell dependabot to ignore that dependency (or temporarily ignore it until the next minor version is released) with a PR comment. I still think auto-updates for major releases are good, but it often warrants that a developer is reading the release notes before it's getting merged.

@timomeh timomeh merged commit df3fe55 into main Apr 30, 2024
4 checks passed
@timomeh timomeh deleted the dependabot branch April 30, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants