Fixed menu toggle and cleaned up unnecessary code. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menu hide didn't work even though the code for hidding it was inside event handler. Now it's fixed. Removed surplus show/hide jQuery function calls as that job is already done by css selectors alone. Removed surplus dropit.settings init to empty array.
…r that. Also there is now setting by which you can disable closing of dropdown on the same action it was opened, so it can only be removed by outside click. keepOpen=false only closes the dropdowns instantiated in the same batch/group There is now simplest possible example page.
…po. My bad, sorry This reverts commit 9c3b84f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu hide didn't work even though the code for hidding it was inside event handler. Now it's fixed.
Removed surplus show/hide jQuery function calls as that job is already done by css selectors alone.
Removed surplus dropit.settings initialization to empty array from the end of the code.