Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AE-1 and/or AE-2 AES encrypted file creation #13

Closed
marcooliveira opened this issue Aug 2, 2012 · 4 comments
Closed

AE-1 and/or AE-2 AES encrypted file creation #13

marcooliveira opened this issue Aug 2, 2012 · 4 comments

Comments

@marcooliveira
Copy link

I'm interested in adding support to create AES encrypted files to this library. Not sure if this was in your roadmap, but I've been taking a look at the specification, and without actually looking to the zip.js implementation in depth, it looks like this is doable. Do you see any pitfall, or do you have any tip on doing this?

Also, from what I understood, zip.js does not support generating the file in chunks, right? From what I understood, If I try to create a 4GB file, the file will be put in RAM/HDD.

Thanks.

@gildas-lormeau
Copy link
Owner

I didn't look deeply in the zip specs to see how encryption is supposed to be integrated but it seems that only deflated/inflated data is encrypted. If this is the case, I guess the best option is to integrate the AES encryption when zip.js appends data coming from deflate/inflate objects. It means it should be done just before writer.writeUint8Array method calls in the onMessageinner function of launchWorkerProcess function, step inner function of copy function, and step inner function of launchProcess function.

@evilaliv3
Copy link

@marcooliveira / @gildas-lormeau what about this ticket? is still something that you consider doable or even on the roadmap?

@marcooliveira
Copy link
Author

Hi @evilaliv3, unfortunately I'm no longer in a position in which I can pursue this, no time. But from what I remember, I think it's relatively simple to execute yourself, if you need it. @gildas-lormeau left some nice tips on how to achieve it.

@gildas-lormeau
Copy link
Owner

It's fixed in the version 2 I just published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants