Fix linting issues introducd by #14 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 69.02% 69.18% +0.16%
==========================================
Files 10 10
Lines 368 370 +2
==========================================
+ Hits 254 256 +2
Misses 114 114
|
rvodden
force-pushed
the
fix_linting
branch
3 times, most recently
from
4213597
to
15a50a9
Compare
|
I've fixed the original linting issue (was a missing blank line). I'm seeing a few strange issues which appear to be caused by the ecosystem. Right now I'm bumping up against this issue: Which appears to be because there isn't a version of black which works with 3.10 and 3.11. I'm reading around the issue now. The python 3,12 issue is because of the removal of distutils from the standard library, which has been deprecated since 3.10. I'll look at that when I've resolved the issue with black. |
|
Great- that's resolved everything except the 3.12 build. Am looking at that now. |
|
I have at least managed to replicate it locally: |
rvodden
force-pushed
the
fix_linting
branch
2 times, most recently
from
1ee5e82
to
4856ab3
Compare
|
OK something odd is going on with pipenv and Python 3.12. I've raised this with pipenv: pypa/setuptools#3661 and temporarily removed 3.12 from the build matrix (our code works under 3.12, so I've not removed it from setup). I'll keep an eye on that bug and raise a new PR when its resolved. @gilesknap over to you - comments, as always, more than welcome. |
|
(as the 3.12 action is no longer running this will no longer succeed, so that check will always show as failed - you'll need to force merge it if you're happy |
|
Thanks @rvodden. Since creating this project the 'skeleton' framework it is based on has moved on from pipenv which is a bit dead now. We just use pip these days. So I'll take an action to get this project updated to the latest skeleton framework. I'm really embedded in another project right now so will get to this in a few weeks. |
|
Great stuff. I've got some ideas about future enhancements , and I've got a few engineers I can potentially enlist for a bit of help. How would you like to discuss these? If you don't have an existing pattern, I suggest that I open a GitHub discussion and we can noodle around on that ahead of opening issues? |
|
Sure. Let's use this #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.