Add Glimmer language #1
Conversation
script/add-grammar https://github.com/lifeart/vsc-ember-syntax Note: I removed `text.html.handlebars` from the `vsc-ember-syntax` in grammars.yml to (hopefully) avoid conficting with the existing Handlebars syntax which is also provided by `vsc-ember-syntax`.
…ber Image and Glimmer languages
| - inline.hbs | ||
| - inline.template | ||
| - source.gjs | ||
| - source.gts |
There was a problem hiding this comment.
I manually removed text.html.handlebars from the vsc-ember-syntax in grammars.yml to (hopefully) avoid conficting with the existing Handlebars grammar.
There was a problem hiding this comment.
Good thinking -- because ember doesn't use handlebars anyway
There was a problem hiding this comment.
Right and we don't want to disrupt users of .hbs/Handlebars (ember or otherwise) with this change.
| - extensions: ['.gts'] | ||
| rules: | ||
| - language: Gerber Image | ||
| pattern: '^G0.' | ||
| - language: Glimmer | ||
| negative_pattern: '^G0.' |
There was a problem hiding this comment.
This might be a bit naive but this is covered by a heuristics test which I think checks the samples/* files 🤷🏻
|
Nice! So excited for this! Thank you!! |
| extensions: | ||
| - ".gjs" | ||
| - ".gts" | ||
| ace_mode: javascript |
There was a problem hiding this comment.
Do we need to add gjs/gts support to the ace editor?
I wrote a parser/syntax package for codemirror 6 -- i wonder if it's similar?
There was a problem hiding this comment.
From the docs:
A String name of the Ace Mode used for highlighting whenever
a file is edited. This must match one of the filenames in https://gh.io/acemodes.
Use "text" if a mode does not exist.
So a full ace mode would probably improve the web editing experience. I don't think that should block this though. We can update that field in a follow-up.
Because otherwise it fails the TestGrammars#test_readme_file_is_in_sync test. Not sure why this URL is considered not in sync. Maybe because of `ace_mode: javascript`?
Description
Adds support for Glimmer.js which will be the component authoring format of the next Edition of Ember.js.
Checklist:
#F5835F