Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert QGLWidget usage to QOpenGLWidget #91

Merged
merged 1 commit into from
May 9, 2018

Conversation

dsboger-zz
Copy link
Contributor

QOpenGLWidget is the modern replacement and has several advantages. In
this case, it fixes #86.

The only big change needed was replacing renderText calls with
QPainter::drawText ones.

QOpenGLWidget is the modern replacement and has several advantages. In
this case, it fixes gillesdegottex#86.

The only big change needed was replacing renderText calls with
QPainter::drawText ones.
@dsboger-zz
Copy link
Contributor Author

dsboger-zz commented May 9, 2018

Some documentation. QOpenGLWidget was introduced in Qt 5.4 (dec/2014) so all currently supported versions of Qt (5.6 LTS, 5.9 LTS and 5.10) should work.

EDIT: I mean supported by Qt upstream.

@gillesdegottex gillesdegottex merged commit f2a0595 into gillesdegottex:master May 9, 2018
@gillesdegottex
Copy link
Owner

Great! Thanks!

@dsboger-zz
Copy link
Contributor Author

I think I know why the travis checks on PRs are passing when they should not. It seems they are using master branch and not the PR branch.

@gillesdegottex
Copy link
Owner

gillesdegottex commented May 9, 2018

Indeed:

$ git checkout $TRAVIS_BRANCH
Warning: you are leaving 2 commits behind, not connected to
any of your branches:
  272f5e1 Merge 56f615d2389503d0e765da2f42d439bcbe350ebc into b8e3d8f7d110d5ae891576c99dd99e9610017cf1
  56f615d Convert QGLWidget usage to QOpenGLWidget
If you want to keep them by creating a new branch, this may be a good time
to do so with:
 git branch <new-branch-name> 272f5e1
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

@gillesdegottex
Copy link
Owner

Ubuntu 18.04 is out now, it seems it was time to switch to xenial builts anyway.

It seems fixed now.

@gillesdegottex
Copy link
Owner

The issue with non-properly checkout PR is still here though.

@dsboger-zz dsboger-zz deleted the gl_views branch May 10, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphical glitches when switching views on/off
3 participants