gettimeofday require "sys/time.h" include on macOS #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux sys/time.h exists and contains gettimeofday, so no need to put an ifdef guard around the include.
|
Hit the same problem and can confirm that this fixes the problem. |
|
Also hit this problem and the fix above works on OSX 10.15.7. |
|
Hit this today. |
mmroz
approved these changes
Mar 31, 2021
mseri
reviewed
Apr 22, 2021
| @@ -6,6 +6,7 @@ | |||
| #include "http_parser.h" | |||
| #include "stats.h" | |||
| #include "zmalloc.h" | |||
| #include "sys/time.h" | |||
There was a problem hiding this comment.
Since sys/time.h is a system header, I think it would be "more correct" to use
#include <sys/time.h> in this case
There was a problem hiding this comment.
On top of @mseri comments, it should be moved to above line 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux sys/time.h exists and contains gettimeofday, so no need to put an ifdef guard around the include.