Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement no_std support #102

Merged
merged 5 commits into from
Aug 30, 2018
Merged

Implement no_std support #102

merged 5 commits into from
Aug 30, 2018

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Aug 4, 2018

Fixes #90

I also changed the travis builds so there's not quite so many builds.

This still needs a gimli update, so the nightly travis build will fail.

@philipc
Copy link
Contributor Author

philipc commented Aug 4, 2018

@roblabla Do you expect any more gimli changes will be needed for the unwind support, or should we do a minor gimli release now?

@roblabla
Copy link

roblabla commented Aug 4, 2018

CC @main-- .

The only other thing unwind-rs' fork had was a bandaid that would parse DW_CFA_GNU_args_size, and ignore this result. From what I read, that implementation is wrong, and anyways is only necessary for i386 windows binaries (source: https://reviews.llvm.org/D38680)

I started a proper implementation for this. I guess we can wait for that before doing a gimli minor bump. I'll try to get a PR up during the week-end.

@main--
Copy link
Contributor

main-- commented Aug 4, 2018

From what I read, that implementation is wrong, and anyways is only necessary for i386 windows binaries

Very interesting, most certainly not how I encountered it but I'm unable to reproduce it so ¯\(ツ)

I started a proper implementation for this. I guess we can wait for that before doing a gimli minor bump. I'll try to get a PR up during the week-end.

Sounds good.

@coveralls
Copy link

coveralls commented Aug 4, 2018

Coverage Status

Coverage remained the same at 75.882% when pulling 48f5eec on philipc:no_std into b1ac5ae on gimli-rs:master.

@est31 est31 mentioned this pull request Aug 9, 2018
14 tasks
@philipc
Copy link
Contributor Author

philipc commented Aug 29, 2018

This should be ready for review/merge now.

@fitzgen fitzgen requested a review from main-- August 29, 2018 20:27
@philipc philipc merged commit 5029589 into gimli-rs:master Aug 30, 2018
@philipc philipc deleted the no_std branch August 30, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants