Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching cpp_demangle from crates.io rebuilds every time #141

Closed
khuey opened this issue May 11, 2018 · 0 comments · Fixed by #142
Closed

Fetching cpp_demangle from crates.io rebuilds every time #141

khuey opened this issue May 11, 2018 · 0 comments · Fixed by #142

Comments

@khuey
Copy link
Collaborator

khuey commented May 11, 2018

Not sure if this is a cpp_demangle issue or a cargo issue, but we'll start here. If I create an empty binary project and put

cpp_demangle = "0.2.8"

in the dependencies, cpp_demangle will rebuild every time I cargo build.

But if I put

cpp_demangle = { git = "https://github.com/gimli-rs/cpp_demangle" }

It works as expected.

Don't have time to dig in at the moment, unfortunately.
fitzgen added a commit that referenced this issue May 14, 2018
@fitzgen
build.rs: Print cargo rerun hints only when files exist
5810600 
A bunch of files exist only when we aren't in a distributed package on
crates.io, and printing the rerun hints when the files are missing will cause
the build.rs to be repeatedly re-ran.

Fixes #141
@fitzgen fitzgen mentioned this issue May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build.rs: Print cargo rerun hints only when files exist gimli-rs/cpp_demangle
1 participant
@khuey