fix: Strip and ignore trailing hashes #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any idea where these come from? I've never seen this before. |
|
Not entirely sure, this is one of the long list of demangling failures we get at sentry. It could be possible that they come from a different step of our pipeline and would need to be stripped out differently. CC @jan-auer ? |
|
I'm not opposed to merging this but I would still like an answer to the question. |
|
Hm, this slipped my radar. We were briefly looking into where these things might come from internally but didn’t find anything obvious looking through the code. I think we can deal with these suffixes in |
loewenheim
added a commit
to getsentry/symbolic
that referenced
this pull request
Mar 11, 2021
This is a port of gimli-rs/cpp_demangle#210 to symbolic-demangle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that some symbols have a
$<32 hex digits>suffix, that when stripped will demangle the symbol perfectly fine.