Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write: implement .debug_line #346

Merged
merged 4 commits into from
Dec 11, 2018
Merged

write: implement .debug_line #346

merged 4 commits into from
Dec 11, 2018

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Dec 8, 2018

The basics are there, but I expect this to evolve a bit as it gets used, both in API and internal data structures.

I've tried to take DWARF version 5 into account, but the support for it is still incomplete.

@philipc philipc requested a review from fitzgen December 8, 2018 04:44
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/write/line.rs Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 87.426% when pulling 30895af on philipc:write-line into bdb7bc9 on gimli-rs:master.

@philipc philipc merged commit d23b4f5 into gimli-rs:master Dec 11, 2018
@philipc philipc deleted the write-line branch December 11, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants